Repository navigation
Make prints in rootfinds portable - #665
Merged
Merged
Conversation
Yurlungur
approved these changes
Oct 27, 2026
Yurlungur
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for these changes!
Collaborator
|
@c-prather can you push after applying formatting? |
Contributor
Author
|
Done! Hopefully clang-format-19 has the same output, I don't still have easy access to 17. This is going to need lanl/ports-of-call#122 still, so if that goes in I can add the submodule bump to this PR rather than opening a new one just for that |
Collaborator
|
thanks for the reminder! merged that one. |
Contributor
Author
|
Bumped ports-of-call! Doesn't look like anything else important changed, hopefully it's a smooth vbump. |
Collaborator
|
We will need a new release of ports-of-call (and spiner) and singularity-eos when we update the spackage and do a new spack release. (Note to me.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace printf with PortsOfCall::printf in the root finding code in Singularity EOS.
Requires ports-of-call to be updated with this before this is useful for SYCL support.
PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: